sound: Fixed line limit issue in sound/ac97_bus.c


From a2c2867876c246420a199a0fb4c36ad2965a42cc Mon Sep 17 00:00:00 2001
From: Jeffrin Jose
Date: Mon, 6 Dec 2010 19:27:53 +0530
Subject: [PATCH] sound: Fixed line limit issue in sound/ac97_bus.c
This is a patch to the sound/ac97_bus.c file that fixes up a 80 character
line limit issue found by the checkpatch.pl tool.
Signed-off-by: Jeffrin Jose

---
sound/ac97_bus.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
index a351dd0..c93251a 100644
--- a/sound/ac97_bus.c
+++ b/sound/ac97_bus.c
@@ -19,9 +19,9 @@

/*
* Let drivers decide whether they want to support given codec from their
- * probe method. Drivers have direct access to the struct snd_ac97 structure and may
- * decide based on the id field amongst other things.
- */
+ * probe method. Drivers have direct access to the struct snd_ac97
+ * structure and may decide based on the id field amongst other things.
+*/
static int ac97_bus_match(struct device *dev, struct device_driver *drv)
{
return 1;
--
1.7.1

touch -c behaves incorrectly (non-POSIX)


http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=439033

POSIX says about 'touch'[*]:

-c
    Do not create a specified file if it does not exist. Do not write
    any diagnostic messages concerning this condition.

[*] http://www.opengroup.org/onlinepubs/009695399/utilities/touch.html

But under some conditions, 'touch' writes a diagnostic message when
the file doesn't exist. For instance:

vin:~> mkdir dir
vin:~> chmod 000 dir
vin:~> /usr/bin/touch -c dir/file
/usr/bin/touch: setting times of `dir/file': Permission denied
zsh: exit 1     /usr/bin/touch -c dir/file
vin:~[1]>

Note that the BSD 'touch' does not have this problem, as shown by the
test below (under Mac OS X):

prunille:~> mkdir dir
prunille:~> chmod 000 dir
prunille:~> /usr/bin/touch -c dir/file
prunille:~>

Also the touch(1) man page doesn't say that no diagnostic messages
are written when the file doesn't exist. Users are not required to
look at the POSIX standard to get the full documentation.

Ditto for the manual (coreutils.info).

coreutils: ls –quoting-style=c and | (pipe) symbol


http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=432945

output of ls --quoting-style=c is incorrect when filename contains |
(pipe) symbol.

Steps:
  mkdir /tmp/bla
  touch "/tmp/bla/filename with | pipe"
  ls --quoting-style=c /tmp/bla

returns:

 "filename with \| pipe"

thanks,
-Mathieu

Ref:
http://groups.google.com/group/comp.lang.c/browse_thread/thread/0db8070def6a4453

coreutils: ls –quoting-style=c and | (pipe) symbol


http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=432945

output of ls --quoting-style=c is incorrect when filename contains |
(pipe) symbol.

Steps:
  mkdir /tmp/bla
  touch "/tmp/bla/filename with | pipe"
  ls --quoting-style=c /tmp/bla

returns:

 "filename with | pipe"

thanks,
-Mathieu

Ref:
http://groups.google.com/group/comp.lang.c/browse_thread/thread/0db8070def6a4453

coreutils: join outputs wrong field order for -v option


join – join lines of two files on a common field

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=410270

Package: coreutils
Version: 5.97-5
Severity: normal


the join field is incorrect for the -v version.

#08-Thu-20-03-40 /tmp$ cat>|a
#a1,a2,c3,a4,a5
#a21,a22,a33,a44,a55
#08-Thu-20-05-07 /tmp$ cat>|b
#b1,b2,b3,c3,b5
#b21,b22,b33,b44,b55
#08-Thu-20-06-07 /tmp$                 join -t, -i -1 3 -2 4 a b
#c3,a1,a2,a4,a5,b1,b2,b3,b5
#08-Thu-20-06-10 /tmp$                 join -v 2 -t, -i -1 3 -2 4 a b
#b33,b21,b22,b44,b55
#08-Thu-20-06-15 /tmp$

thanks.

-- System Information:
Debian Release: 4.0
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16nomd
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

coreutils: stty reports bogus error.


http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=404497

Consider the session below:

$ stty -F /dev/ttyS0 9600
$ stty -F /dev/ttyS0 -g > stty.ttyS0.txt
$ stty -F /dev/ttyS0 115200
$ stty -F /dev/ttyS0 `cat stty.ttyS0.txt`
stty: /dev/ttyS0: unable to perform all requested operations
$ stty -F /dev/ttyS0 `cat stty.ttyS0.txt`
$

As far as I can tell, the (bogus) error message is due to the stty's
ignorance of c_ispeed and c_ospeed fields of struct termios.

dd oflag=append : imply notrunc, or improve documentation


http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=373736

On Mon, Jun 26, 2006 at 12:18:46PM -0400, Michael Stone wrote:
>
> You probably want conv=notrunc

uh! thanks for the tip

but still I see some kind of bug in this, lets say
a documentation bug

1) conv=???? is supposed to be
   "convert the file as per the comma separated symbol list"

 IMHO, "do not truncate the output file" is not a conversion
 in any possible imaginable way; I would understand more
 if it was  "oflag=notrunc"

2) what is the use of  "oflag=append" when one forgets
 "conv=notrunc"

So I propose some improvements:

a) add oflag=notrunc
 (leaving conv=notrunc for back compatibility)

b) oflag=append implies conv=notrunc

c) a line may be added in the man page, saying that
 oflag=append is useless w/o conv=notrunc

I will retitle the bug

a.

--
Andrea Mennucc